Escolar Documentos
Profissional Documentos
Cultura Documentos
Minutes
Date of Review MM / DD / YYYY
Item(s) to Review
Description of
Item(s), Background
and Context
Objectives of Review
Owner(s) of Item(s)
Who is Impacted?
Who Depends on
these Items?
Reviewed by
Next Steps
Coding standards should be considered to be guidelines rather than strict rules. That being said,
developers should try to follow these recommendations as closely as possible … your lives will be much
easier as a result.
Use FxCop
FxCop is a tool that will help you to improve the quality of your code. To read more about it visit the
following link …
http://msdn.microsoft.com/library/default.asp?url=/msdnmag/issues/04/06/Bugslayer/toc.asp
http://www.amazon.com/gp/product/0735619670/103-3384042-5349424?v=glance&n=283155
http://msdn2.microsoft.com/en-us/library/ms998530.aspx
Maintainability, Adaptability
Assess factors that will impact the ease with which the software may be maintained or altered over time.
group of classes
Coupling: Inter-Layer
Dependencies
The more method calls you
have from one class in a
given assembly or “logical
layer” to other classes in a
different assembly or
“logical layer”, the tighter
the coupling, and the
harder it will be to
maintain over time.
Encapsulation, Information
Hiding, Inappropriate
Intimacy between Classes
When classes know too
much about the internals
of each other, they become
very tightly coupled and
hard to maintain.
Speculative Generality
A.K.A. You Aren’t Going to
DesignPatternsFor.Net Code Review Printed 1/20/2006 12:51:00 a1/p1 Page 4 of 9
Template
Code Review
Minutes
Date of Review MM / DD / YYYY
Need It
Versioning Approach
Has the developer
produced an approach that
may be easily versioned
over time?
Use of Interfaces
Are interfaces used
appropriately?
Simplicity of Solution
Appropriate Use of
Comments
General adherence to
Microsoft Coding Standards
Robustness
Assess the primary factors that affect how well the software handles incorrect data or unforeseen
scenarios.
Performance
Assess the areas that will typically have the greatest impact on application performance.
Loop considerations
Loops are exited as soon
as conditions met
String Handling
Assess string
concatenation approaches
Resource Cleanup
Resources are acquired
late and released early
of “using” statement
Appropriate use of
ViewState and Postback
checking
Use of Code
Instrumentation
Premature Optimization?
Supporting Documentation
Assess the design solution’s need for supporting documentation
Sequence Diagrams
Entity-Relationship
Diagrams
Other Diagram
Where will
Documentation be
Migration Considerations
Assess how current or future users (i.e. developers) dependent on this solution will migrate to the
proposed approach. How will the risk of breaking changes be minimized?